Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contributing some changes back #11

Merged
merged 6 commits into from
Aug 3, 2023
Merged

Contributing some changes back #11

merged 6 commits into from
Aug 3, 2023

Conversation

SeanKilleen
Copy link
Contributor

If you'd like to merge them; your call.

  • Introduces ruby 2.7.4 / GitHub Pages 228 Support into the matrix of published containers
  • Introduces node v20 into the matrix of published containers
  • Updates npm upon installing node in the container.

@SeanKilleen
Force a build
a105c9c
@SeanKilleen
Set IMAGE_NAME via shell output
9656f3d
@SeanKilleen
Merge pull request #1 from SeanKilleen/lowercase_repo_name
79d251f 
Lowercase repo name to provide to IMAGE_NAME
@SeanKilleen
Install latest npm during node installation (#5)
e016588
@SeanKilleen
Update dependencies matrix (#6)
0315e78 
* Ruby 2.7.3->2.7.4 in dockerfile

* GH Pages 226->228 in Dockerfile

* node version 16->18 in Dockerfile

* Update matrix to use pairs where appropriate

* update env variables to use the new matrix values

* spacing
@SeanKilleen
Allow write permissions to the GitHub Action (#7)
6126c3e
@SeanKilleen
Copy link
Contributor Author

CC @duluca in case Excella is interested in this. 👍 feel free to close if not

@SeanKilleen SeanKilleen mentioned this pull request Aug 3, 2023
Closed
@duluca
Copy link
Contributor

duluca commented Aug 3, 2023

Awesome, thanks for the contribution!

@duluca duluca merged commit 24bea90 into excellalabs:main Aug 3, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SeanKilleen @duluca