patch: actualizado workflow y mejoras de código

* Se actualiza version de actions/checkout * Mejorada lectura de código en logger.utils.ts * Se agregan "migas" de sentry al recibir errores
exdevutem · May 3, 2024 · 1684b46 · 1684b46
1 parent 7bd0e74
commit 1684b46
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 18 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -1,7 +1,4 @@
-# This workflow will do a clean installation of node dependencies, cache/restore them, build the source code and run tests across different versions of node
-# For more information see: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-nodejs
-
-name: Node Tests
+name: Node Test
 
 on:
   push:
@@ -20,7 +17,7 @@ jobs:
         node-version: [18, 20]
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - name: 'Setup Node.js'
         uses: actions/setup-node@v4
         with:

diff --git a/src/infrastructure/server/server.ts b/src/infrastructure/server/server.ts
@@ -84,10 +84,6 @@ export default class Server {
       res: Response,
       next: NextFunction
     ) {
-      GenericLogger.log({
-        level: "error",
-        message: err.stack,
-      });
       if (err instanceof GenericError) {
         let uid: string;
         try {
@@ -103,10 +99,21 @@ export default class Server {
           }
         }
 
-        console.error({
+        Sentry.addBreadcrumb({
+          category: 'error',
           message: 'Obtuvimos un error de tipo "GenericError" en el servidor',
-          error: err,
+          level: 'error',
+          data: {
+            error: err,
+            uid,
+          }
         })
+
+
+        GenericLogger.log({
+          level: "error",
+          message: err.stack,
+        });
         res.statusCode = err.statusCode;
         res.json({
           codigoHttp: err.statusCode ? err.statusCode : 500,
@@ -115,6 +122,7 @@ export default class Server {
           error: err.message,
         });
       } else {
+        Sentry.captureException(err);
         res.statusCode = 500;
         res.json({
           codigoHttp: 500,

diff --git a/src/infrastructure/utils/logger.utils.ts b/src/infrastructure/utils/logger.utils.ts
@@ -45,13 +45,7 @@ export default class GenericLogger {
     ],
   });
 
-  public static log({
-                      level = "info",
-                      message = "",
-                    }: {
-    level?: string;
-    message?: string;
-  }) {
+  public static log({ level = "info", message = "" }: { level?: string; message?: string; }) {
     this.logger.log({level, message});
   }
 }