Exercise/raindrops #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: update config.json and add hello-world exercise (#3)
|
I saw right now, I have to add newline at end each new file. |
ErikSchierboom
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
To be consistent, this file should probably be called Raindrops.bat
There was a problem hiding this comment.
To be consistent, this file should probably be called RaindropsTest.bat
|
@ErikSchierboom Hi Erik, thanks for your review. Can you check is there any other problem? |
|
@GroophyLifefor I don't see the names of the file being changed. You might need to do |
|
@ErikSchierboom I do in this comment right now c51e281 but doesn't affected to this PR, I'm not sure why. |
|
I can look into it next week. I'll approve |
|
Could you look at failing ci? |
|
@ErikSchierboom CI/CD fixed. |
|
Feel free to merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New exercise implementation.
https://github.com/exercism/problem-specifications/blob/main/exercises/raindrops/instructions.md