Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#48in24: anagram #767

Merged
merged 5 commits into from
Jul 13, 2024
Merged

#48in24: anagram #767

merged 5 commits into from
Jul 13, 2024

Conversation

fejan-malek
Copy link
Contributor

#734

  • Change: Added all the missing testcases
  • Also removed unused testcases.

Copy link

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@mk-mxp
Copy link
Contributor

mk-mxp commented Jun 28, 2024

@fejan-malek You were too early with this one. 2024-07-23 minus 2 weeks = 2024-07-09. Please do not haste forward, it causes extra work.

I'll leave this opened. On 2024-07-09 (or some days after) please re-run the configlet sync command and rebase this branch. Thanks for your patience!

@mk-mxp mk-mxp added x:action/sync Sync content with its latest version x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:type/content Work on content (e.g. exercises, concepts) x:size/small Small amount of work x:rep/small Small amount of reputation labels Jul 7, 2024
Copy link
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice work! You are helping very much.

exercises/practice/anagram/AnagramTest.php Outdated Show resolved Hide resolved
exercises/practice/anagram/AnagramTest.php Outdated Show resolved Hide resolved
exercises/practice/anagram/AnagramTest.php Outdated Show resolved Hide resolved
exercises/practice/anagram/AnagramTest.php Outdated Show resolved Hide resolved
@fejan-malek fejan-malek requested a review from mk-mxp July 13, 2024 07:25
Copy link
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for helping with this one!

@mk-mxp mk-mxp merged commit 02e377f into exercism:main Jul 13, 2024
12 checks passed
@fejan-malek fejan-malek deleted the sync-anagram branch July 13, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:action/sync Sync content with its latest version x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:rep/small Small amount of reputation x:size/small Small amount of work x:type/content Work on content (e.g. exercises, concepts)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants