Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Allergies #771

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Sync Allergies #771

merged 1 commit into from
Jul 8, 2024

Conversation

fejan-malek
Copy link
Contributor

#761

We need to update the testdox and uuid comments in the test case.

And this exercise also contains dataprovider test.

Copy link

github-actions bot commented Jul 6, 2024

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@mk-mxp
Copy link
Contributor

mk-mxp commented Jul 7, 2024

@fejan-malek I will take a deeper look into this. May take some days to answer.

@mk-mxp mk-mxp added x:action/sync Sync content with its latest version x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:type/content Work on content (e.g. exercises, concepts) x:size/small Small amount of work x:rep/small Small amount of reputation labels Jul 7, 2024
@mk-mxp
Copy link
Contributor

mk-mxp commented Jul 8, 2024

@fejan-malek I remember doing this exercise, and I struggled heavily with the design of the exercise. And I am not the only one: Track status says, that only 49% finished the exercise. In addition, only 82 persons finished it at all.

So we should not invest more into the current state of the exercise. I will merge the changes you already made. Maybe you want to help re-writing the exercise? See #772

Copy link
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@mk-mxp mk-mxp merged commit 40620ed into exercism:main Jul 8, 2024
13 checks passed
@fejan-malek fejan-malek deleted the sync-allergies branch July 8, 2024 11:30
@fejan-malek
Copy link
Contributor Author

So we should not invest more into the current state of the exercise. I will merge the changes you already made. Maybe you want to help re-writing the exercise? See #772

Sure @mk-mxp Will take a look because I never contribute to developing an exercise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:action/sync Sync content with its latest version x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:rep/small Small amount of reputation x:size/small Small amount of work x:type/content Work on content (e.g. exercises, concepts)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants