Sync Knapsack

[fejan-malek]

#782

This PR contains no major changes except @testdox updated in test case file.

[github-actions]

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

[mk-mxp]

@fejan-malek Do you have time to re-structure the tests like this:

    public function testNoItems(): void
    {
        $expected = 0;
        $maximumWeight = 100;
        $items = [];

        $knapsack = new Knapsack();
        $actual = $knapsack->getMaximumValue($maximumWeight, $items);

        $this->assertEquals($expected, $actual);
    }

This would greatly enhance readability for students using the online editor. The current test methods do not contain the object creation and the long lines require scolling horizontally.

If you have no time, I will do that after merging your PR. That is OK, we all have a life besides Exercism.

[fejan-malek]

Yes, I am a little busy with a project at work.

Do we need to implement this in all test cases or only this single test case?

[mk-mxp]

Perfect! Thank you very much. And it's not "late", it's just in time 😃