Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Rotational cipher #799

Merged
merged 3 commits into from
Sep 8, 2024
Merged

Conversation

fejan-malek
Copy link
Contributor

[no important files changed]

#791

  • Only testdox comment added in testcases.

[no important files changed]
Copy link

github-actions bot commented Sep 7, 2024

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@mk-mxp mk-mxp added x:action/sync Sync content with its latest version x:knowledge/none No existing Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:type/content Work on content (e.g. exercises, concepts) x:size/small Small amount of work x:rep/small Small amount of reputation labels Sep 7, 2024
@mk-mxp mk-mxp self-requested a review September 7, 2024 07:39
Copy link
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Everything is OK, only one optional change may be done.

To enhance readability in the online editor, you may move the object construction from setUp() to the individual tests like this:

    public function testRotateAByZero(): void
    {
        $expected = 'a';
        $rotationalCipher = new RotationalCipher();

        $actual = $rotationalCipher->rotate('a', 0);

        $this->assertEquals($expected, $actual);
    }

Copy link
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for all your contributions.

@mk-mxp mk-mxp merged commit 73c2fd5 into exercism:main Sep 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:action/sync Sync content with its latest version x:knowledge/none No existing Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:rep/small Small amount of reputation x:size/small Small amount of work x:type/content Work on content (e.g. exercises, concepts)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants