Sync: Bob

[tomasnorre]

Resolves #805

[github-actions]

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

[mk-mxp]

Thanks a lot for this! Some inputs are still out of sync.

For better readability in the online editor, you may optionally inline the object instantiation, apply the Arrange-Act-Assert pattern and keep lines shorter than about 60 characters like this:

    public function testStatingSomething(): void
    {
        $input = "Tom-ay-to, tom-aaaah-to.";
        $expected = "Whatever.";

        $subject = new Bob();
        $actual = $subject->respondTo($input)

        $this->assertEquals($expected, $actual);
    }

[tomasnorre]

For better readability in the online editor, you may optionally inline the object instantiation, apply the Arrange-Act-Assert pattern and keep lines shorter than about 60 characters like this:

Thanks for you input, i'll look into it.

[tomasnorre]

I don't know how the test runner would deal with it, but I would prefer personally to have a constant for each answer, to avoid risk of typos and minimize work.

const ANSWER_WHATEVER = "Whatever."
const ANSWER_SURE = "Sure."
const ANSWER_FINE = "Fine. Be that way!"
... 

[mk-mxp]

I don't know how the test runner would deal with it, but I would prefer personally to have a constant for each answer, to avoid risk of typos and minimize work.

const ANSWER_WHATEVER = "Whatever."
const ANSWER_SURE = "Sure."
const ANSWER_FINE = "Fine. Be that way!"
... 

In the online editor feedback, you will never see the string such constant stands for. So, please, keep the string duplicated, even if it is against all rules of real production code.

[mk-mxp]

Thanks for syncing this exercise!

[tomasnorre]

@mk-mxp Can you please assign the correct labels to the latest PRs.

[mk-mxp]

@mk-mxp Can you please assign the correct labels to the latest PRs.

Sorry, I sometimes quickly check in to merge and forget the boring details...

[tomasnorre]

No worries, I would expect at least some of the labels could be automated, based on lines changed e.g. with the x:size labels.