Fix largest-series-products tests #623
Conversation
We deleted a couple of tests from the test suite but they were still being referenced from allTests. This deletes the stray references.
* Sync largest-series-product docs with problem-specifications The largest-series-product exercise has been overhauled as part of a project to make practice exercises more consistent and friendly. For more context, please see the discussion in the forum, as well as the pull request that updated the exercise in the problem-specifications repository: - https://forum.exercism.org/t/new-project-making-practice-exercises-more-consistent-and-human-across-exercism/3943 - exercism/problem-specifications#2246 * Delete test cases from largest-series-product This deletes two deprecated test cases so that we can dramatically simplify the instructions for this exercise.
|
I think the old test runner had a reference to the allTests. |
|
That would explain why CI passed 😅 |
|
@meatball133 Is |
|
I will be honest, I am not sure. But I think there were some kind of requirement to have it since swift couldn't find tests by itself and then Apple made so you didn't anymore, I think this pr added it for linux: swiftlang/swift-package-manager#2174 Here can you see one of apples repo updating its tests files: https://github.com/apple/swift-syntax/pull/171/files |
|
So... maybe we can remove them everywhere. I will make a PR and we can see what happens. |
|
Concept exercises have 2 additional files. But yes I think we could try to remove them. |
We deleted a couple of tests from the test suite
but they were still being referenced from allTests.
This deletes the stray references.