Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(doc): Fix build of doc and return error on warning #63

Merged
merged 1 commit into from
Oct 11, 2024
Merged

fix(doc): Fix build of doc and return error on warning #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@

# You can set these variables from the command line, and also
# from the environment for the first two.
SPHINXOPTS ?=
# If there is an issue in the build process, for example import error in the "reading process" job of sphinx-build
# It will only raise warning which won't make the job in the CI fail, but the HTML page will be empty.
# Therefore, we add the "--fail-on-warning" option.
SPHINXOPTS ?= --fail-on-warning
SPHINXBUILD ?= sphinx-build
SOURCEDIR = docs
BUILDDIR = build
Expand Down
3 changes: 2 additions & 1 deletion exoscale/api/v2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ def _call_operation(self, operation_id, parameters=None, body=None):
raise ExoscaleAPIAuthException(
f"Authentication error {response.status_code}: {response.text}"
)
if response.status_code >= 400 and response.status_code < 500:
if 400 <= response.status_code < 500:
raise ExoscaleAPIClientException(
f"Client error {response.status_code}: {response.text}"
)
Expand All @@ -185,6 +185,7 @@ def _call_operation(self, operation_id, parameters=None, body=None):
"object": "dict",
"array": "list",
"boolean": "bool",
"number": "float",
}


Expand Down