Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add var.prefix to aws_iam_role name #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hall
Copy link

@hall hall commented Jul 9, 2024

Since this module is meant to be created per EKS cluster, this change allows having multiple clusters in the same AWS account, each with their own IAM role.

Since this module is meant to be created per EKS cluster, this change
allows having multiple clusters in the same AWS account, each with their
own IAM role.
@hall hall requested a review from a team as a code owner July 9, 2024 19:53
@hall
Copy link
Author

hall commented Jul 10, 2024

Oh, I do want to point out that this is a breaking change and will require users to update the role name in the Expel dashboard.

@hall
Copy link
Author

hall commented Jul 10, 2024

Since this is a breaking change, it might also be worth changing the IAM role casing as it doesn't match that of the kinesis data stream and cloudwatch subscription filter.

However, it would be nice to shorten some of these hard-coded suffices (or altogether remove the ones which are redundant like -kinesis-data-stream on a Kinesis data stream) to increase the max limit on the length of var.prefix (though I'm not entirely sure which resource name that limit is coming from).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant