Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update langchain pin to 0.0.331 #357

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Update langchain pin to 0.0.331 #357

merged 2 commits into from
Nov 8, 2023

Conversation

rmitsch
Copy link
Collaborator

@rmitsch rmitsch commented Nov 8, 2023

Description

Update langchain pin to 0.0.331.

Corresponding documentation PR

-

Types of change

Chore.

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran all tests in tests and usage_examples/tests, and all new and existing tests passed. This includes
    • all external tests (i. e. pytest ran with --external)
    • all tests requiring a GPU (i. e. pytest ran with --gpu)
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@rmitsch rmitsch added chore Chore third party Third-party software (integrations etc.) labels Nov 8, 2023
@rmitsch rmitsch self-assigned this Nov 8, 2023
@rmitsch
Copy link
Collaborator Author

rmitsch commented Nov 8, 2023

Note: run external tests before merging once OpenAI API works again.

Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge once we can get the tests to run and they go green!

@rmitsch rmitsch added the Test external Run external tests label Nov 8, 2023
@rmitsch
Copy link
Collaborator Author

rmitsch commented Nov 8, 2023

For posterity: the openai pin is necessary due to a conflict of langchain with openai > 0.28.1. See langchain-ai/langchain#12967.

@rmitsch rmitsch merged commit 7a5d108 into main Nov 8, 2023
11 checks passed
@rmitsch rmitsch deleted the chore/update-langchain-pin branch November 17, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore Test external Run external tests third party Third-party software (integrations etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants