Add workaround for langchain
model ID issue
#374
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add workaround for
langchain
model ID issue:langchain
doesn't use a standardized arg name for models (anymore?). This clumsy workaround tries a number of known arg names. Follow-up solutions might be smarter by reading out the validation errors and fixing the model, but at this point it's not clear whether this would even be a more robust solution.Fixes #373 and #372.
Corresponding documentation PR
-
Types of change
Bug fix.
Checklist
tests
andusage_examples/tests
, and all new and existing tests passed. This includespytest
ran with--external
)pytest
ran with--gpu
)