Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update readme #401

Merged
merged 10 commits into from
Jan 5, 2024
Merged

Update readme #401

merged 10 commits into from
Jan 5, 2024

Conversation

rmitsch
Copy link
Collaborator

@rmitsch rmitsch commented Dec 13, 2023 •
edited
Loading

Description

  • Add logo to readme.
  • Update title.
  • Update model links.

Corresponding documentation PR

-

Types of change

Readme update.

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran all tests in tests and usage_examples/tests, and all new and existing tests passed. This includes
    • all external tests (i. e. pytest ran with --external)
    • all tests requiring a GPU (i. e. pytest ran with --gpu)
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@rmitsch rmitsch added the documentation Improvements or additions to documentation label Dec 13, 2023
@rmitsch rmitsch self-assigned this Dec 13, 2023
@rmitsch
Copy link
Collaborator Author

rmitsch commented Dec 13, 2023

See https://github.com/explosion/spacy-llm/blob/chore/add-logo/README.md for how this would look like.

@rmitsch rmitsch changed the title Add logo to readme Update readme Dec 14, 2023
@rmitsch rmitsch changed the base branch from main to develop December 27, 2023 12:27
@rmitsch
Merge branch 'develop' into chore/add-logo
e380c9d 
# Conflicts:
#	spacy_llm/models/rest/anthropic/registry.py
#	spacy_llm/models/rest/cohere/registry.py
#	spacy_llm/models/rest/openai/registry.py
#	spacy_llm/models/rest/palm/registry.py
svlandeg
svlandeg reviewed Dec 29, 2023
View reviewed changes
Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to the readme look good. I think we can revert the changes to the .py files, though I worry how they crept in from the merge?

@rmitsch
Copy link
Collaborator Author

rmitsch commented Jan 5, 2024 •
edited
Loading

Reverted code changes.

@svlandeg svlandeg merged commit b8ae128 into develop Jan 5, 2024
10 checks passed
@svlandeg svlandeg deleted the chore/add-logo branch January 5, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svlandeg svlandeg svlandeg approved these changes

Assignees

@rmitsch rmitsch

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmitsch @svlandeg