Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] better runtime version error for bare workflow #1910

Merged
merged 3 commits into from
Jul 3, 2023

Conversation

quinlanj
Copy link
Member

@quinlanj quinlanj commented Jun 30, 2023

Why

People on the bare workflow are running eas update with a runtimeVersion policy. When they receive our original error message, they don't know what to do. This PR changes the error message to be more actionable.

Fixes #1689 and #1899

Test Plan

  • Manually tested

@quinlanj quinlanj requested a review from wschurman June 30, 2023 21:14
@quinlanj
Copy link
Member Author

/changelog-entry chore better bare workflow runtimeVersion error

@quinlanj quinlanj marked this pull request as ready for review June 30, 2023 21:15
@github-actions
Copy link

github-actions bot commented Jun 30, 2023

Size Change: -4.71 kB (0%)

Total Size: 41.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 41.9 MB -4.71 kB (0%)

compressed-size-action

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #1910 (81f622a) into main (c199173) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             main    #1910    +/-   ##
========================================
  Coverage   52.58%   52.58%            
========================================
  Files         480      480            
  Lines       17316    17316            
  Branches     3460     3645   +185     
========================================
  Hits         9104     9104            
+ Misses       8195     7536   -659     
- Partials       17      676   +659     
Impacted Files Coverage Δ
packages/eas-cli/src/project/publish.ts 79.93% <ø> (ø)

... and 185 files with indirect coverage changes

@ildaneta
Copy link

ildaneta commented Jul 2, 2023

@quinlanj When I try to put sdkVersion: "47.0.0", "runtimeVersion: "1.0.0" in the app.config.ts file it doesn't work when I have to test the EAS update with the QR Code generated inside the expo.dev.

Screenshot 2023-07-02 at 12 38 42

It only works when I set:

runtimeVersion: "exposdk:47.0.0",
sdkVersion: "47.0.0",
Screen_Recording_20230702_123306_Expo.Go.mp4

So I don't know if just changing the error is the solution.

I think you might have to test this situation using a simple expo bare project, add EAS update, create a new update and test this scenario.
Also, I think the documentation should consider this case.

@quinlanj
Copy link
Member Author

quinlanj commented Jul 3, 2023

@ildaneta we've fixed this issue and have relaxed the runtime constraints on Expo Go. As long as your project has a compatible expo npm package installed, Expo Go will load your project. Please note that the same challenges will apply in the bare workflow -- if a native module is not bundled in Expo Go but is referenced in the JS layer of your app, an error will be thrown.

The changes are expected to be released very soon for the SDK 49 release. It will officially be available when the next version of Expo Go is released into the App Stores.

@quinlanj quinlanj force-pushed the @quin/betterRuntimeError branch from 81f622a to 34c0365 Compare July 3, 2023 21:41
@github-actions
Copy link

github-actions bot commented Jul 3, 2023

✅ Thank you for adding the changelog entry!

@quinlanj quinlanj merged commit 9bf2020 into main Jul 3, 2023
@quinlanj quinlanj deleted the @quin/betterRuntimeError branch July 3, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Runtime version policies are only supported in the managed workflow
3 participants