Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli][eas-json] use node18 as tsconfig base #2739

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

quinlanj
Copy link
Member

@quinlanj quinlanj commented Dec 4, 2024

Why

Followup from #2736 (comment)

Standardize TypeScript configuration across packages by adopting the recommended Node.js 18 TypeScript configuration. This helps ensure consistent TypeScript settings and reduces configuration duplication.

How

  • Added @tsconfig/node18 dependency to eas-cli and eas-json packages
  • Extended the base Node 18 TypeScript configuration in both packages
  • Removed redundant compiler options that are already included in the Node 18 preset
  • Updated module resolution strategy to explicitly use "node"

Test Plan

Current tests pass

Copy link
Member Author

quinlanj commented Dec 4, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Dec 4, 2024

❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md.
⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

Copy link

github-actions bot commented Dec 4, 2024

Size Change: -17.2 kB (-0.03%)

Total Size: 52.6 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.6 MB -17.2 kB (-0.03%)

compressed-size-action

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.73%. Comparing base (868fd39) to head (00e73c5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2739   +/-   ##
=======================================
  Coverage   52.73%   52.73%           
=======================================
  Files         580      580           
  Lines       22280    22280           
  Branches     4358     4358           
=======================================
  Hits        11747    11747           
  Misses      10498    10498           
  Partials       35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quinlanj quinlanj marked this pull request as ready for review December 4, 2024 00:42
Copy link

github-actions bot commented Dec 4, 2024

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela
packages/eas-json/** @szdziedzic, @khamilowicz, @sjchmiela

Generated by CodeMention

@quinlanj quinlanj mentioned this pull request Dec 4, 2024
1 task
Copy link
Member

@szdziedzic szdziedzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable (after merge conflicts are resolved and tests stop failing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants