Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] show deployment errors #2771

Merged
merged 5 commits into from
Dec 13, 2024
Merged

Conversation

kadikraman
Copy link
Contributor

Why

The error messages from 403 upload error were not being shown in the terminal.

How

Extract the error message from 403 errors and show to the user when applicable.

Test Plan

Tested locally by uploading a build with 100+ assets.

Before / After

Before

Screenshot 2024-12-13 at 11 47 08

After

Screenshot 2024-12-13 at 15 37 55

@kadikraman kadikraman requested a review from kitten December 13, 2024 15:46
Copy link

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

Copy link

github-actions bot commented Dec 13, 2024

Size Change: +395 B (0%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB +395 B (0%)

compressed-size-action

@kadikraman kadikraman requested a review from kitten December 13, 2024 17:02
Copy link

✅ Thank you for adding the changelog entry!

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 52.52%. Comparing base (ab3495d) to head (c18fc9c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/worker/upload.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2771   +/-   ##
=======================================
  Coverage   52.52%   52.52%           
=======================================
  Files         583      583           
  Lines       22576    22576           
  Branches     4450     4450           
=======================================
  Hits        11855    11855           
  Misses      10686    10686           
  Partials       35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kadikraman kadikraman merged commit 6a55c65 into main Dec 13, 2024
10 checks passed
@kadikraman kadikraman deleted the @kadikraman/show-deployment-errors branch December 13, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants