Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] Update deploy/alias log output copy #2780

Merged
merged 5 commits into from
Dec 19, 2024
Merged

[eas-cli] Update deploy/alias log output copy #2780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6f5371a
Update product name
kitten Dec 19, 2024
231d6e9
Highlight `Project export` text
kitten Dec 19, 2024
49d0997
Update export copy
kitten Dec 19, 2024
9ca9575
Update product name for alias
kitten Dec 19, 2024
a093059
Add changelog entry
kitten Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ This is the log of notable changes to EAS CLI and related packages.

### 🧹 Chores

- Update log output for `worker` deploy and alias commands. ([#2780](https://github.com/expo/eas-cli/pull/2780) by [@kitten](https://github.com/kitten))

## [14.2.0](https://github.com/expo/eas-cli/releases/tag/v14.2.0) - 2024-12-13

### 🎉 New features
Expand Down
2 changes: 1 addition & 1 deletion packages/eas-cli/src/commands/worker/alias.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ export default class WorkerAlias extends EasCommand {
enableJsonOutput();
}

Log.warn('EAS Worker Deployments are in beta and subject to breaking changes.');
Log.warn('EAS Hosting is still in beta and subject to changes.');

const {
getDynamicPrivateProjectConfigAsync,
Expand Down
9 changes: 5 additions & 4 deletions packages/eas-cli/src/commands/worker/deploy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ export default class WorkerDeploy extends EasCommand {
enableJsonOutput();
}

Log.warn('EAS Worker Deployments are in beta and subject to breaking changes.');
Log.warn('EAS Hosting is still in beta and subject to changes.');

const {
getDynamicPrivateProjectConfigAsync,
Expand Down Expand Up @@ -426,7 +426,7 @@ async function resolveExportedProjectAsync(

if (!exportDirStat?.isDirectory()) {
throw new Error(
`No "${flags.exportDir}/" folder found. Prepare your project for deployment with "npx expo export --platform web"`
`No "${flags.exportDir}/" folder found. Export your app with "npx expo export --platform web"`
);
}

Expand All @@ -451,7 +451,8 @@ function logExportedProjectInfo(
// Only show the timestamp for exports older than 1 minute
if (project.modifiedAt && Date.now() - project.modifiedAt.getTime() > 60_000) {
modifiedAgo = ` - exported ${formatTimeAgo(project.modifiedAt)}`;
Log.warn(`> Project export: ${project.type}${modifiedAgo}}`);
} else {
Log.log(chalk`{dim > Project export: ${project.type}}`);
}

Log.log(chalk`{dim > Project export: ${project.type}${modifiedAgo}}`);
}
Loading