Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] Combine .env and EAS environment variables for deploy command #2783

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kitten
Copy link
Member

@kitten kitten commented Dec 20, 2024

Why

This allows --environment to be combined with local .env files, outputting a warning when any variables conflict since EAS environment variables will take precedence.

How

  • Update createManifestAsync to return manifest and conflicting variable names
  • Always call getEnv and merge variables into the env object
  • Output names when conflicts occurred

Test Plan

  • Tested locally

Copy link

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

@kitten kitten force-pushed the @kitten/feat/deploy-env-and-eas-env-simultaneously branch from c6eb6e7 to 04a5671 Compare December 20, 2024 14:22
Copy link

github-actions bot commented Dec 20, 2024

Size Change: +3.04 kB (+0.01%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB +3.04 kB (+0.01%)

compressed-size-action

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 52.49%. Comparing base (a1d086f) to head (0be4a4f).

Files with missing lines Patch % Lines
packages/eas-cli/src/worker/assets.ts 0.00% 11 Missing ⚠️
packages/eas-cli/src/commands/worker/deploy.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2783      +/-   ##
==========================================
- Coverage   52.51%   52.49%   -0.01%     
==========================================
  Files         583      583              
  Lines       22582    22589       +7     
  Branches     4452     4454       +2     
==========================================
  Hits        11856    11856              
- Misses      10691    10698       +7     
  Partials       35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kitten kitten force-pushed the @kitten/feat/deploy-env-and-eas-env-simultaneously branch from 18ea25b to 0be4a4f Compare December 20, 2024 19:13
Copy link

✅ Thank you for adding the changelog entry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant