Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] create debug fingerprints #2797

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

quinlanj
Copy link
Member

@quinlanj quinlanj commented Jan 5, 2025

Why

Create a debug fingerprint upon every build, update and local fingerprint computation.

Test Plan

  • manually tested build
  • manually tested update
  • manually tested fingerprint:compare

Copy link
Member Author

quinlanj commented Jan 5, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Jan 5, 2025

❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md.
⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

@quinlanj quinlanj marked this pull request as ready for review January 5, 2025 20:44
Copy link

github-actions bot commented Jan 5, 2025

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

Copy link

github-actions bot commented Jan 5, 2025

Size Change: -3.16 kB (-0.01%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB -3.16 kB (-0.01%)

compressed-size-action

Copy link

codecov bot commented Jan 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.50%. Comparing base (5e5b55f) to head (a4ca87a).

Files with missing lines Patch % Lines
packages/eas-cli/src/build/build.ts 0.00% 1 Missing ⚠️
...ckages/eas-cli/src/commands/fingerprint/compare.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2797      +/-   ##
==========================================
- Coverage   52.51%   52.50%   -0.00%     
==========================================
  Files         583      583              
  Lines       22582    22583       +1     
  Branches     4452     4452              
==========================================
  Hits        11856    11856              
- Misses      10691    10692       +1     
  Partials       35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@Kudo Kudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code change looks okay but wondering the reason the have debug fingerprint for every builds.

Copy link
Member

@wschurman wschurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @Kudo's comment. Thus far we've tended to only do a debug fingerprint when EXPO_DEBUG env is set: https://github.com/expo/eas-cli/blob/main/packages/eas-cli/src/project/resolveRuntimeVersionAsync.ts#L34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants