-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eas-cli] create debug fingerprints #2797
base: main
Are you sure you want to change the base?
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md. |
Subscribed to pull request
Generated by CodeMention |
Size Change: -3.16 kB (-0.01%) Total Size: 53.4 MB
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2797 +/- ##
==========================================
- Coverage 52.51% 52.50% -0.00%
==========================================
Files 583 583
Lines 22582 22583 +1
Branches 4452 4452
==========================================
Hits 11856 11856
- Misses 10691 10692 +1
Partials 35 35 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code change looks okay but wondering the reason the have debug fingerprint for every builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @Kudo's comment. Thus far we've tended to only do a debug fingerprint when EXPO_DEBUG
env is set: https://github.com/expo/eas-cli/blob/main/packages/eas-cli/src/project/resolveRuntimeVersionAsync.ts#L34
Why
Create a debug fingerprint upon every build, update and local fingerprint computation.
Test Plan