Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: keywords field #210

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Conversation

bjohansebas
Copy link
Member

The funding field has already been launched in Express; it might be a good idea to add it to the packages the organization has

Related: expressjs/discussions#228

@bjohansebas bjohansebas requested review from UlisesGascon and a team December 6, 2024 00:24
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will like to have an additional @expressjs/express-tc approval before landing (cc: @wesleytodd )

@bjohansebas bjohansebas requested a review from wesleytodd January 8, 2025 21:57
@bjohansebas bjohansebas mentioned this pull request Jan 8, 2025
@wesleytodd
Copy link
Member

Yeah, this one will mean a new line in every install from npm asking for funding. Feels to me like we should do that work to define how we plan on spending money before risking taking on too much before we have docs on it all. If we want to update the tags separately that would be faster to land. In the mean time I think we need to work on that spending plan anyway, so I will see about consolidating those discussions in the next few weeks to a single ADR in the discussions repo.

@bjohansebas
Copy link
Member Author

I can remove that field in the meantime, but didn't this expressjs/discussions#299 define how the resources were going to be used?

@wesleytodd
Copy link
Member

I forgot I had that PR. I will be updating those soon and trying to get them landed. Until it is landed though just opening the PR without agreement with the team it doesn't really mean much. I think we should remove it in the mean time.

Copy link
Member

@sheplu sheplu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjohansebas bjohansebas changed the title docs: add funding and keywords field docs: keywords field Jan 9, 2025
@wesleytodd wesleytodd merged commit 82c9cb5 into expressjs:master Jan 10, 2025
32 checks passed
@bjohansebas bjohansebas deleted the metadata-package branch January 10, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants