-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade cookie to 0.6.0 #105
Conversation
@UlisesGascon I believe there's an issue with node 8 and 9 tests. |
@UlisesGascon Can you re-run the github action please? I believe it has been fixed by #104. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work on this @6km!
The CI issues are related to #104, so it can be ignored (with a rebase can be solved).
Seems like this PR should add the changes in the HISTORYmd
too, see.
I think that we can release currently what is unrelased and the then merge this PR, so the end users can migrate in smaller steps if they want.
QQ: I understand we should be updating the module anyway, but from technical perspective, is this cookie to 0.6.0 upgrade required for partitioned purpose? |
This should be bumped to 0.7.0, as 0.6.0 is affected by this; GHSA-pxg6-pf52-xh8x |
The dependency version should not be pinned to allow automatic upgrade |
surpassed #116 |
Update
cookie
to supportpartitioned
option.close #102.