Skip to content

Commit

Permalink
ci: fix errors in ci github action for node 8 and add support for new…
Browse files Browse the repository at this point in the history
…er versions (#322)

PR-URL: #322
  • Loading branch information
inigomarquinez authored May 14, 2024
1 parent de19afc commit 791983e
Showing 1 changed file with 33 additions and 4 deletions.
37 changes: 33 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,12 @@ jobs:
- Node.js 12.x
- Node.js 14.x
- Node.js 16.x
- Node.js 17.x
- Node.js 18.x
- Node.js 19.x
- Node.js 20.x
- Node.js 21.x
- Node.js 22.x

include:
- name: Node.js 0.10
Expand All @@ -34,7 +40,7 @@ jobs:

- name: Node.js 8.x
node-version: "8.17"
npm-i: [email protected]
npm-i: [email protected] [email protected]

- name: Node.js 10.x
node-version: "10.24"
Expand All @@ -49,8 +55,26 @@ jobs:
- name: Node.js 16.x
node-version: "16.6"

- name: Node.js 17.x
node-version: "17.6"

- name: Node.js 18.x
node-version: "18.14"

- name: Node.js 19.x
node-version: "19.6"

- name: Node.js 20.x
node-version: "20.12"

- name: Node.js 21.x
node-version: "21.7"

- name: Node.js 22.x
node-version: "22.0"

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4

- name: Install Node.js ${{ matrix.node-version }}
shell: bash -eo pipefail -l {0}
Expand All @@ -59,7 +83,12 @@ jobs:
dirname "$(nvm which ${{ matrix.node-version }})" >> "$GITHUB_PATH"
- name: Configure npm
run: npm config set shrinkwrap false
run: |
if [[ "$(npm config get package-lock)" == "true" ]]; then
npm config set package-lock false
else
npm config set shrinkwrap false
fi
- name: Install npm module(s) ${{ matrix.npm-i }}
run: npm install --save-dev ${{ matrix.npm-i }}
Expand Down Expand Up @@ -114,7 +143,7 @@ jobs:
needs: test
runs-on: ubuntu-latest
steps:
- name: Uploade code coverage
- name: Upload code coverage
uses: coverallsapp/github-action@master
with:
github-token: ${{ secrets.github_token }}
Expand Down

0 comments on commit 791983e

Please sign in to comment.