(exa PR) 1221: add icon support for .mjs, .cjs, .mts, .cts files #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cargo tests are all okay. I don't have the icons font needed.
Testing requested
|
cafkafk
changed the title
cafkafk
added
features › icon
and removed
help wanted
These are javascript/typescript files that specify the module type (in NodeJS). Thusly, they should have icons matching their language (JS/TS). Co-authored-by: aarondill <[email protected]> Signed-off-by: Christina Sørensen <[email protected]>
(.mjs is excluded bc webpack doesn't currently support it) Co-authored-by: aarondill <[email protected]> Signed-off-by: Christina Sørensen <[email protected]>
Signed-off-by: Christina Sørensen <[email protected]>
|
Tested it and it works |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ogham/exa#1221