FieldType context #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
May 19, 2015 07:23
Conflicts: Context/EzContext.php
| */ | ||
| public function createContentTypeWithRequiredFieldType( $fieldType, $name = null ) | ||
| { | ||
| return $this->getFieldTypeManager()->createField( $fieldType, $name, true ); |
There was a problem hiding this comment.
doesn't seem to do anything else then method above, missing something?
There was a problem hiding this comment.
One creates a required field, the other one a non-required one.
There was a problem hiding this comment.
Ah, I was missing the true and thought the line where completely the same, indeed :)
|
with the comments here resolved I'm +1 |
| */ | ||
| protected function destroy( ValueObject $object ) | ||
| { | ||
| // do nothing for now, to be implemented later when decided waht to do with the created objects |
There was a problem hiding this comment.
Here can't be thrown an exception because this method is always called and that would make all the tests fail. This method is related to the created object removal and we decided to implement later because of the possible problems that creating objects with platformUI brings.
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FieldType
Base implementation for the FieldType sentences. Mostly prerequisites are implemented here on the Behat level, in conjunction with the PlatformUICore ezsystems/PlatformUIBundle#230 implements the sentences for the FieldTypes as in ezsystems/PlatformUIBundle#211.