This repository has been archived by the owner on May 3, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 47
[Behat] Add Behat test for issue EZP-25642 users 'Delete' button #553
Open
miguelcleverti
wants to merge
11
commits into
ezsystems:master
Choose a base branch
from
miguelcleverti:ezp_5642_BehatTests
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
980df25
[Behat] Add Behat test for issue EZP-25642 users 'Delete' button
9eafc7f
[Behat] minor comment syntax fix
d1591ab
[Behat] Improve 'I should see action bar button' sentence
b641dea
[Behat] Improve 'I should see action bar button' method argument
1fa996f
[Behat] Add 'I should not see action bar button' sentence
e79ba26
[Behat] Improve 'I go to User page' sentence
515e519
[Behat] Change 'iShouldSeeActionBarButton' exception for assertion
0538b73
[Behat] Fix User edit sentence fetches the first and last name of the…
98a533b
[Behat] minor User sentence typo and Scenario description fix
daaff8e
[Behat] Fix User page sentence fetches the first and last name of the…
389f07a
[Behat] Add default User creation and sentence
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -67,3 +67,9 @@ Feature: Use the eZ Users field | |
And I fill in "Password" with "12345" | ||
And I fill in "Confirm password" with "123456" | ||
Then I should see error messages | ||
|
||
@javascript @edge | ||
Scenario: Validate "Send to trash" button is replaced with "Delete" when browsing users | ||
When I go to a valid User page | ||
Then I should not see a "Send to trash" action bar button | ||
And I should see a "Delete" action bar button | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We could replace "and" with "but", I think it works too. And it sounds a bit better :-) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should move this to an
ActionBarContext
.