This repository has been archived by the owner on May 3, 2022. It is now read-only.
[travis] added strings check #751
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpobel
suggested changes
Dec 1, 2016
|
|
||
| RETURN=0 | ||
|
|
||
| if test "$ADDED_MESSAGES" != 0; then |
There was a problem hiding this comment.
usually this is written with [] instead of test and also to avoid any ambiguity, I would compare against "0" not 0, so something like:
if [ "$ADDED_MESSAGES" != "0" ] ; then| echo "Failure: strings need to be regenerated" | ||
| fi | ||
|
|
||
| exit "$RETURN"; |
There was a problem hiding this comment.
nitpick: exit $RETURN is enough :)
bdunogier
force-pushed
the
ezp26731-travis_check_strings
branch
from
9277bd5
to
e43e705
Compare
bdunogier
force-pushed
the
ezp26731-travis_check_strings
branch
from
c4a136e
to
b0b4c03
Compare
andrerom
suggested changes
Dec 16, 2016
| @@ -0,0 +1,6 @@ | |||
| #!/usr/bin/env sh | |||
| ../../../app/console translation:extract en -v \ | |||
There was a problem hiding this comment.
maybe change to run from project root as they seems to depend on that anyway? (and check if in root while at it, this is placed in public folder, aka no .<folder> like .travis, so should probably do some sanity checks before running)
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runs the
bin/updatestrings.sh(also part of this PR) script in dry-run mode, frombin/travis/checkstrings.sh, and fails ifthe pull-request add nor remove strings.