This repository has been archived by the owner on May 3, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 47
PlatformUI translation doc #818
Open
StephaneDiot
wants to merge
1
commit into
master
Choose a base branch
from
PlatformUI_translation_doc
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephaneDiot
force-pushed
the
PlatformUI_translation_doc
branch
from
March 6, 2017 12:49
7cf8855
to
4c9cbe2
Compare
You could add a note reminding telling people to be careful not to commit translation while if only the date of generation has been updated. |
yannickroger
approved these changes
Mar 9, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With feedback taken into account
@@ -157,3 +157,12 @@ Then, you can run the unit tests with: | |||
``` | |||
$ php vendor/bin/phpunit | |||
``` | |||
|
|||
* Translation | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should add a link to the doc explaining the translation process.
|
||
* Translation | ||
|
||
To generate the .xlf translation file (in PlatformUIBundle/Ressources/translations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you added new translation strings,
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the developer's tasks of the README.md about how to generate translated strings in PlatformUI