Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-6134: Changed ANCHOR_PATTERN to be compatible with xml:id because cannot have : character #235

Merged
merged 1 commit into from
Jul 14, 2023
Merged

IBX-6134: Changed ANCHOR_PATTERN to be compatible with xml:id because cannot have : character #235

merged 1 commit into from
Jul 14, 2023

Conversation

mateuszdebinski
Copy link
Contributor

Question Answer
JIRA issue IBX-6134
Bug/Improvement yes
New feature no
Target version v3.3
BC breaks no
Tests pass yes
Doc needed no

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@mateuszdebinski mateuszdebinski added Bug Something isn't working Ready for review labels Jul 4, 2023
@mateuszdebinski mateuszdebinski requested a review from a team July 4, 2023 13:42
@mateuszdebinski mateuszdebinski self-assigned this Jul 4, 2023
@mateuszdebinski mateuszdebinski requested a review from a team July 7, 2023 13:29
@micszo micszo self-assigned this Jul 10, 2023
micszo
micszo approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on Ibexa Commerce 3.3.34-dev.

@micszo micszo removed their assignment Jul 13, 2023
@dew326 dew326 merged commit e89026a into 2.3 Jul 14, 2023
20 checks passed
@dew326 dew326 deleted the IBX-6134_remove_colon_character branch July 14, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@dew326 dew326 dew326 approved these changes

@micszo micszo micszo approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@Gengar-i Gengar-i Gengar-i approved these changes

@tischsoic tischsoic Awaiting requested review from tischsoic

Assignees

@alongosz alongosz

@dew326 dew326

@mateuszdebinski mateuszdebinski

Labels
Bug Something isn't working QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mateuszdebinski @GrabowskiM @dew326 @micszo @lucasOsti @Gengar-i @alongosz