Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-1756: Added id to custom tags #238

Merged
merged 2 commits into from
Aug 1, 2023
Merged

IBX-1756: Added id to custom tags #238

merged 2 commits into from
Aug 1, 2023

Conversation

Gengar-i
Copy link
Contributor

Question Answer
JIRA issue IBX-1756
Bug/Improvement bug
New feature no
Target version latest stable for bug fixes, master for new features
BC breaks no
Tests pass yes
Doc needed yes

Added id to custom tags

TODO:

  • Implement feature / fix a bug.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@micszo micszo self-assigned this Jul 27, 2023
@micszo
Copy link
Member

micszo commented Jul 27, 2023

What about custom tags which are not added OOTB (https://doc.ibexa.co/en/3.3/extending/extending_online_editor/#configure-custom-tags)?
Do we need a doc PR as well? And mention this id there too?

micszo
micszo approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anchors work fine with YouTube, Twitter and Facebook custom tags.

Discussed dev doc update matter separately.

CI failures are related to unchanged files.

QA Approved on Ibexa Commerce 3.3.34-dev.

@micszo micszo removed their assignment Aug 1, 2023
@adamwojs adamwojs merged commit 6bff30d into 2.3 Aug 1, 2023
12 of 16 checks passed
@adamwojs adamwojs deleted the ibx-1756-anchor-does-not-work branch August 1, 2023 11:54
@alongosz alongosz mentioned this pull request Aug 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@tischsoic tischsoic tischsoic approved these changes

@dew326 dew326 dew326 approved these changes

@micszo micszo micszo approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

Assignees

@alongosz alongosz

@dew326 dew326

@konradoboza konradoboza

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Gengar-i @micszo @GrabowskiM @tischsoic @dew326 @lucasOsti @adamwojs @alongosz @konradoboza