IBX-8258: richtext: Html5Input is not washed for duplicate IDs #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steveb-p
approved these changes
Jun 13, 2024
src/lib/eZ/RichText/Resources/stylesheets/xhtml5/edit/docbook.xsl
Outdated
Show resolved
Hide resolved
konradoboza
reviewed
Jun 13, 2024
tests/lib/eZ/RichText/Converter/Xslt/_fixtures/xhtml5/edit/lossy/010-duplicatedIds.docbook.xml
Outdated
Show resolved
Hide resolved
konradoboza
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
Apart from nitpick https://github.com/ezsystems/ezplatform-richtext/pull/243/files#r1637781380.
Steveb-p
approved these changes
Jun 27, 2024
This was referenced Jul 3, 2024
bogusez
approved these changes
Jul 4, 2024
vidarl
force-pushed
the
IBX-8258_richtext_Html5Input_is_not_washed_for_duplicate_IDs
branch
from
95e999d
to
8258cc9
Compare
konradoboza
deleted the
IBX-8258_richtext_Html5Input_is_not_washed_for_duplicate_IDs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XSLT stylesheet doesn't check if ids are unique. I wasn't able to reproduce the problem reported in IBX-8258 with the alloy editor ( IDs are note included in the cut&paste operation when performed on Alloy it seems). It is reproducable on the CKEditor in 4.6
The problem is nevertheless represented in the XSLT stylesheet in 3.3 as well
Note: When merging to 4.6, remember to adopt for changes in XML namespaces in new fixtures
TODO:
$ composer fix-cs).