Skip to content
This repository has been archived by the owner on Apr 4, 2019. It is now read-only.

Add gzip encoding by default #254

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

peterkeung
Copy link

We should add gzip encoding by default

@ezrobot
Copy link
Contributor

ezrobot commented Dec 22, 2017

@dfearnley
Copy link

Should be included as part of the default +1

@ernestob
Copy link

Compression should be there by default.

👍

@carlosmauri
Copy link

carlosmauri commented Dec 22, 2017

Agree. we should include it. By adding this the site gets a better score at:
https://developers.google.com/speed/pagespeed/insights/
which is important in terms of SEO
👍

@andrerom
Copy link
Contributor

Could someone move this over to ezplatform repo for apache and nginx? (this repo is not used anymore) _And maybe add inline recommendation on how to deal with it when using Varnish. Should we adapt the default VCL as well pherhaps? _

@peterkeung
Copy link
Author

PR on "ezplatform" repo: ezsystems/ezplatform#251

I considered creating a separate vhost example for the legacy bridge, but it's well enough documented here: https://github.com/ezsystems/LegacyBridge/blob/master/INSTALL.md

@@ -188,4 +188,9 @@
#ExpiresDefault "now plus 30 days"
#</LocationMatch>
</IfModule>

# Enable gzip encoding
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apache default config for when mod_deflate already includes a few of these. Would it not be better to only add here the missing ones? Or at least add a comment mentioning mention that

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

7 participants