Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php-cs-fixer, PhpStorm #34

Open
wants to merge 40 commits into
base: master
Choose a base branch
from
Open

Conversation

mambax7
Copy link

@mambax7 mambax7 commented Jun 11, 2018

cherry-pick whatever you like

@f3l1x
Copy link
Member

f3l1x commented Jun 13, 2018

Hi. It's awesome. 👍 ❤️

Have you tried it, it's all working?

@mambax7
Copy link
Author

mambax7 commented Jun 13, 2018

Unfortunately, I didn't have the time to try it. Maybe somebody else can test it....

@mambax7
Copy link
Author

mambax7 commented Jun 13, 2018

There are still some issues there, but I won't have time at the moment to continue:
https://scrutinizer-ci.com/g/mambax7/nusoap/issues/feature/php-cs-fixer/files/src/nusoap.php?orderField=path&order=asc&honorSelectedPaths=0

@f3l1x
Copy link
Member

f3l1x commented Jul 23, 2018

Hi @mambax7. Are you still working on that? I would like to merge it. :-)

@mambax7
Copy link
Author

mambax7 commented Jul 23, 2018

Not at the moment, so cherry-pick whatever you like and merge. This is not tested at all, so please review before you merge...

@f3l1x f3l1x mentioned this pull request Aug 1, 2018
9 tasks
@f3l1x f3l1x force-pushed the master branch 2 times, most recently from f034663 to cb4d0dc Compare July 5, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants