mpi: fix detection of local messages in receiver

faasm · Feb 26, 2024 · 65cd6af · 65cd6af
1 parent 4d738ad
commit 65cd6af
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/mpi/MpiWorld.cpp b/src/mpi/MpiWorld.cpp
@@ -607,7 +607,8 @@ void MpiWorld::doRecv(std::shared_ptr<MPIMessage>& m,
     assert(m->count() <= count);
 
     const std::string otherHost = getHostForRank(m->destination());
-    bool isLocal = otherHost == thisHost;
+    bool isLocal =
+      getHostForRank(m->destination()) == getHostForRank(m->sender());
 
     if (m->count() > 0) {
         if (isLocal) {

diff --git a/src/planner/Planner.cpp b/src/planner/Planner.cpp
@@ -290,7 +290,10 @@ void Planner::setMessageResult(std::shared_ptr<faabric::Message> msg)
 
     // Release the slot only once
     if (!state.hostMap.contains(msg->executedhost())) {
-        SPDLOG_ERROR("Host Map does not contain: {}", msg->executedhost());
+        SPDLOG_ERROR("Host Map does not contain: {}. We have:", msg->executedhost());
+        for (auto [ip, host] : state.hostMap) {
+            SPDLOG_ERROR("{} ({}/{})", ip, host->usedslots(), host->slots());
+        }
     }
     assert(state.hostMap.contains(msg->executedhost()));
     if (!state.appResults[appId].contains(msgId)) {