Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NNG panics #325

Closed
wants to merge 3 commits into from
Closed

Fix NNG panics #325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d19b5cb
gha: try to make nng panic every time in gha
csegarragonz Jun 20, 2023
07836ed
gha: use single quotes instead?
csegarragonz Jun 20, 2023
26249de
trying things
csegarragonz Jun 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,9 @@ jobs:
run: ./bin/inv_wrapper.sh dev.cmake --clean --build=Debug --sanitiser ${{ matrix.sanitiser }}
- name: "Build tests"
run: ./bin/inv_wrapper.sh dev.cc faabric_tests
# Try to make the NNG panics consistent in GHA
- name: "Run one conflicting test in repeat"
run: /build/faabric/static/bin/faabric_tests "Test starting and stopping the function migration thread"
- name: "Run tests"
run: ./bin/inv_wrapper.sh tests

Expand Down
4 changes: 3 additions & 1 deletion src/transport/MessageEndpoint.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,11 +279,13 @@ void MessageEndpoint::sendMessage(uint8_t header,

nng_aio_set_msg(aio, msg);

/*
if (context.has_value()) {
nng_ctx_send(*context, aio);
} else {
*/
nng_send_aio(socket, aio);
}
// }

nng_aio_wait(aio);
int ec = nng_aio_result(aio);
Expand Down