Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move static clients from scheduler to their respective header #339

Merged
merged 3 commits into from
Jul 28, 2023

Conversation

csegarragonz
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #339 (3630165) into main (74b12aa) will decrease coverage by 0.06%.
The diff coverage is 95.34%.

❗ Current head 3630165 differs from pull request most recent head 613b210. Consider uploading reports for the commit 613b210 to get more accurate results

@@            Coverage Diff             @@
##             main     #339      +/-   ##
==========================================
- Coverage   82.04%   81.98%   -0.06%     
==========================================
  Files          98       98              
  Lines        7964     7972       +8     
==========================================
+ Hits         6534     6536       +2     
- Misses       1430     1436       +6     
Files Changed Coverage Δ
include/faabric/scheduler/Scheduler.h 42.85% <ø> (ø)
src/planner/PlannerClient.cpp 80.00% <80.00%> (ø)
src/planner/Planner.cpp 92.66% <100.00%> (-0.72%) ⬇️
src/planner/PlannerEndpointHandler.cpp 84.24% <100.00%> (ø)
src/scheduler/FunctionCallClient.cpp 88.42% <100.00%> (+1.21%) ⬆️
src/scheduler/Scheduler.cpp 91.67% <100.00%> (-0.19%) ⬇️
src/snapshot/SnapshotClient.cpp 93.70% <100.00%> (+0.42%) ⬆️

... and 1 file with indirect coverage changes

@csegarragonz csegarragonz merged commit b81cdaa into main Jul 28, 2023
4 checks passed
@csegarragonz csegarragonz deleted the clients branch July 28, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant