Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove message from scheduling decision #352

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Conversation

csegarragonz
Copy link
Collaborator

@csegarragonz csegarragonz commented Sep 6, 2023

This PR adds a utility method to remove a message from a scheduling decision.

Useful for #353

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #352 (f7807d0) into main (9ccf899) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #352      +/-   ##
==========================================
+ Coverage   81.39%   81.42%   +0.03%     
==========================================
  Files         102      102              
  Lines        7857     7870      +13     
==========================================
+ Hits         6395     6408      +13     
  Misses       1462     1462              
Files Changed Coverage Δ
...clude/faabric/batch-scheduler/SchedulingDecision.h 100.00% <ø> (ø)
src/batch-scheduler/SchedulingDecision.cpp 91.93% <100.00%> (+2.13%) ⬆️

@csegarragonz csegarragonz merged commit 6af1cda into main Sep 6, 2023
12 of 13 checks passed
@csegarragonz csegarragonz deleted the remove-from-decision branch September 6, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant