wip: test transport layer improvements #386
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
benchmark results with #385 and #379 benchmark results with #385 and #379 and #387 (result of |
|
looks like it is on par with #382. What's their difference? |
|
@lgarithm that is great news! this PR is meant to be the same than #382 but is just a pure merge of #385 and #379 (both passing all the tests) so before merging both of them i wanted to make sure that in the upstreaming process i did not mess up in any way i am also re-building the production containers to triple-check if we can see some improvement (or no regression) in our production workload. after that, i will merge the two linked prs in. |
csegarragonz
force-pushed
the
spinlock-plus-struct-test
branch
from
d260e99
to
b5b8123
Compare
csegarragonz
changed the title
csegarragonz
force-pushed
the
spinlock-plus-struct-test
branch
2 times, most recently
from
3db65f3
to
578c079
Compare
|
@lgarithm could you run the benchmarks with the latest commit i have added and include the results where it says note that i've cleaned-up the commit history to make sure we know which commit introduces what, so this may affect your merging/rebasing. |
csegarragonz
force-pushed
the
spinlock-plus-struct-test
branch
from
98947e7
to
578c079
Compare
This commit moves the abstraction of a PTP message from a protobuf object to a fixed-size C-struct with a heap pointer. The rationale is that these PTP messages move through the system, and even when careful it is challenging to keep track of the copies allocations that protobuf is doing under the hood. In exchange, we are very explicity about the copies and allocations we do.
csegarragonz
force-pushed
the
spinlock-plus-struct-test
branch
from
3f0f4d7
to
b7f0042
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR combines:
we will merge them separately, but ideally we want to have both PRs above green, and then measure the benefits (hopefully we are on par with #382)