Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(tcp): add test for blocking recv sockets #420

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Conversation

csegarragonz
Copy link
Collaborator

Add test for blocking RECV TCP sockets and add a catch for when we are trying to receive from a client that has already disconnected.

Add test for blocking RECV TCP sockets and add a catch for when we are
trying to receive from a client that has already disconnected.
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@440189f). Click here to learn what that means.

Files Patch % Lines
src/transport/tcp/RecvSocket.cpp 50.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #420   +/-   ##
=======================================
  Coverage        ?   82.18%           
=======================================
  Files           ?      116           
  Lines           ?     7561           
  Branches        ?        0           
=======================================
  Hits            ?     6214           
  Misses          ?     1347           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@csegarragonz csegarragonz merged commit e5ffe83 into main Apr 16, 2024
12 checks passed
@csegarragonz csegarragonz deleted the test-block branch April 16, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant