transport(tcp): set send/recv buffer sizes #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this PR we add support to set the send and receive buffer sizes. OpenMPI does not set them, but we were failing when sending some large messages. In addition, and similarly to OpenMPI we need to appropriately set the kernel parameters for TCP.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #426 +/- ##
==========================================
+ Coverage 82.20% 82.26% +0.06%
==========================================
Files 115 115
Lines 7565 7586 +21
==========================================
+ Hits 6219 6241 +22
+ Misses 1346 1345 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we add support to set the send and receive buffer sizes. OpenMPI does not set them, but we were failing when sending some large messages. In addition, and similarly to OpenMPI we need to appropriately set the kernel parameters for TCP.