Skip to content

Commit

Permalink
Use lowest supported Python version for checks
Browse files Browse the repository at this point in the history
We should do formatting, linting, testing, and so on
against the lowest Python version that we intend to support.
We want to make sure we do not introduce unsupported Python syntax.
Because Python is generally backwards-compatible
this should be good enough to check against lowest version.
  • Loading branch information
fabcor-maxiv authored and marcus-oscarsson committed Jun 28, 2024
1 parent 5914478 commit 59a8d77
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build_and_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
strategy:
max-parallel: 5
matrix:
python-version: ["3.10"]
python-version: ["3.8"]

# Skip `pull_request` runs on local PRs for which `push` runs are already triggered
# yamllint disable-line rule:line-length
Expand Down
3 changes: 1 addition & 2 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
---

default_language_version:
python: python3.10

python: python3.8 # This should be set to the lowest Python version that we support.

repos:

Expand Down

0 comments on commit 59a8d77

Please sign in to comment.