Skip to content

Commit

Permalink
Receive and store new parameter "deregisteredAt", but do not include …
Browse files Browse the repository at this point in the history
…it when registering a new revision (not supported)
  • Loading branch information
fabfuel committed Mar 23, 2021
1 parent 7e7991c commit 454ca6f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
3 changes: 2 additions & 1 deletion ecs_deploy/ecs.py
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ class EcsTaskDefinition(object):
def __init__(self, containerDefinitions, volumes, family, revision,
status, taskDefinitionArn, requiresAttributes=None,
taskRoleArn=None, executionRoleArn=None, compatibilities=None,
tags=None, registeredAt=None, registeredBy=None, **kwargs):
tags=None, registeredAt=None, deregisteredAt=None, registeredBy=None, **kwargs):

self.containers = containerDefinitions
self.volumes = volumes
Expand All @@ -241,6 +241,7 @@ def __init__(self, containerDefinitions, volumes, family, revision,
# task definition. Just storing them for now.
self.compatibilities = compatibilities
self.registered_at = registeredAt
self.deregistered_at = deregisteredAt
self.registered_by = registeredBy

@property
Expand Down
1 change: 1 addition & 0 deletions tests/test_ecs.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@
u'placementConstraints': {},
u'registeredBy': 'foobar',
u'registeredAt': '2021-01-20T14:33:44Z',
u'deregisteredAt': '2021-01-20T14:33:44Z',
u'unknownProperty': u'lorem-ipsum',
u'compatibilities': [u'EC2'],
}
Expand Down

0 comments on commit 454ca6f

Please sign in to comment.