fix(proxy): do not register the server socket into server socket list

[jmaitrehenry]

No description provided.

[fabienvauchelles]

There is an issue: the proxy doesn't correctly shutdown. You can run the tests and there are about 15 not working.

[jmaitrehenry]

@fabienvauchelles how do you run the test? I didn't see any issue on my side for the last days.

[fabienvauchelles]

You can run the test with:

DOTENV_FILE=packages/backend/test/src/assets/storage-file.env npm run test

Here is the content of the packages/backend/test/src/assets/storage-file.env file:

PROXY_REFRESH_DELAY=200
FREEPROXY_REFRESH_DELAY=200
CONNECTORS_REFRESH_EMPTY_DELAY=500
PROXIES_REFRESH_EMPTY_DELAY=500
ASSETS_PATH=dist/scrapoxy/assets
STORAGE_TYPE=file
STORAGE_FILE_FILENAME=scrapoxy-test.json
PYTHON=/home/fabien/.virtualenvs/scrapoxy/bin/python
JAVA=/usr/bin/java
AUTH_GITHUB_CLIENT_SECRET=fake_secret
AUTH_GOOGLE_CLIENT_SECRET=fake_secret
FRONTEND_JWT_SECRET=frontendsecret
BACKEND_JWT_SECRET=backendsecret

I've got also a config file packages/backend/test/src/assets/storage-distributed.env for distributed test:

PROXY_REFRESH_DELAY=200
FREEPROXY_REFRESH_DELAY=200
CONNECTORS_REFRESH_EMPTY_DELAY=500
PROXIES_REFRESH_EMPTY_DELAY=500
ASSETS_PATH=dist/scrapoxy/assets
STORAGE_TYPE=distributed
STORAGE_DISTRIBUTED_MONGO_DB=scrapoxytest
PYTHON=/home/fabien/.virtualenvs/scrapoxy/bin/python
JAVA=/usr/bin/java
AUTH_GITHUB_CLIENT_SECRET=fake_secret
AUTH_GOOGLE_CLIENT_SECRET=fake_secret
FRONTEND_JWT_SECRET=frontendsecret
BACKEND_JWT_SECRET=backendsecret

[fuad00]

looks like REMOVING* this.sockets.add(socket); does the job. i really want to see it in prod!