Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bug with newest dagger version #90

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Frisch12
Copy link

In the newest dagger version the builder is not created with methods for setting the modules but with fields for holding the modules.
This fix will try to look for the method and if no method with module name is found, it will search for a field named as the module.
So every combination of dagger versions is possible.

@fabioCollini
Copy link
Owner

Thanks for the PR! Is there an alternative way to do it and avoid using an api available only on Android 24+? The library is a java module so it shouldn't contain any android library dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants