Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PYDEVD_REMOTE_ROOT support #243

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

thejcannon
Copy link

This change intends to fix microsoft/debugpy#1130 by allowing for a env var (PYDEVD_REMOTE_ROOT) to unconditionally configure the remote root when set in the server's environment.

@thejcannon
Copy link
Author

I couldn't find a good place to add a test for this. LMK where one belongs

@fabioz
Copy link
Owner

fabioz commented Dec 8, 2022

Thanks for taking a look at this.

Some notes:

  1. There should be an integration test in tests_python/test_debugger_json.py (you can use another test as a base -- test_case_stop_async_iteration_exception has an example which customizes environment variables).
  2. Most constants are set in _pydevd_bundle.pydevd_constants. I think this should be a constant there (initialized from that environment variable value).
  3. If that variable is set it should be logged in pydevd._log_initial_info.

@thejcannon
Copy link
Author

  • Added integration test. Fails without changes, passes with
  • now using a defined constant
  • logging the constant if set

@thejcannon
Copy link
Author

@fabioz wanna give this another look?

@thejcannon
Copy link
Author

Bump

@thejcannon
Copy link
Author

@fabioz are you able to take a look? 😄

@fabioz
Copy link
Owner

fabioz commented Oct 5, 2024

Sorry for the long time to review this. The change seems fine. Do you think you can fix the conflicts and resubmit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow server to configure its root
2 participants