Update tools/inkscape_extension/visicut_export.py

dirname() should be fine to. It is more readable. Thanks! (not sure if introducing a new apprun_path variable contributes to readability though ...) But I don't mind. Co-authored-by: TheAssassin <[email protected]>
fablabnbg · Apr 8, 2024 · ab42570 · ab42570
1 parent e435f2e
commit ab42570
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/tools/inkscape_extension/visicut_export.py b/tools/inkscape_extension/visicut_export.py
@@ -337,13 +337,13 @@ def get_original_filename(filename):
 # We detect this by checking for an AppRun file, in one of the parent folders of our INKSCAPEBIN.
 # If so, replace INKSCAPEBIN with AppRun, as this is the only safe way to call inkscape.
 # (a direct call mixes libraries from the host system with the appimage, may or may not work.)
-dir = os.path.split(INKSCAPEBIN)[0]
+dir = os.path.dirname(INKSCAPEBIN)
 while dir != '/':
-    if os.path.exists(os.path.join(dir, "AppRun")):
-        INKSCAPEBIN = os.path.join(dir, "AppRun")
+    apprun_path = os.path.join(dir, "AppRun")
+    if os.path.exists(apprun_path):
+        INKSCAPEBIN = apprun_path
         break
-    dir = os.path.split(dir)[0]
-
+    dir = os.path.dirname(dir)
 tmpdir = tempfile.mkdtemp(prefix='temp-visicut-')
 dest_filename = os.path.join(tmpdir, get_original_filename(filename))