Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add controllers in LitElement.init #27

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add controllers in LitElement.init #27

wants to merge 4 commits into from

Conversation

alfonsogarciacaro
Copy link
Member

See #26

AngelMunoz
AngelMunoz reviewed Dec 3, 2021
View reviewed changes
src/Lit/Lit.fs Outdated Show resolved Hide resolved
AngelMunoz
AngelMunoz approved these changes Dec 3, 2021
View reviewed changes
Copy link
Collaborator

@AngelMunoz AngelMunoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change is good seems a bit weird to register controllers on the specific property but I can see why

alfonsogarciacaro and others added 3 commits December 5, 2021 10:04
@alfonsogarciacaro
Fix tests
892c0d9
@AngelMunoz @alfonsogarciacaro
Add ReactiveControllerbase
724f7fb 
Add each method as an interface so consumers can implement their own controllers without every method if needed
@AngelMunoz
Merge branch 'master' into controllers
55523f3
@OnurGumus
Copy link

Any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AngelMunoz AngelMunoz AngelMunoz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alfonsogarciacaro @OnurGumus @AngelMunoz