Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Fable-FCS to F# 9 #3960

Merged
merged 4 commits into from
Jan 14, 2025
Merged

Updated Fable-FCS to F# 9 #3960

merged 4 commits into from
Jan 14, 2025

Conversation

ncave
Copy link
Collaborator

@ncave ncave commented Nov 22, 2024

  • Updated Fable-FCS to F# 9
  • Updated metadata to .NET 9.0

@ncave ncave marked this pull request as draft November 22, 2024 11:36
@ncave
Copy link
Collaborator Author

ncave commented Nov 22, 2024

On hold until #3957 is merged

@MangelMaxime
Copy link
Member

@ncave I rebase this branch onto main.

Is it now the next branch we need to merge?

@ncave
Copy link
Collaborator Author

ncave commented Nov 28, 2024

@MangelMaxime No, not yet, it needs more work to translate to JS some new .net code that got in FCS since last year. I may not be able to work on that in the next few weeks, but we should be good to stick with the old repl until then, it only affects the repl.

@MangelMaxime
Copy link
Member

Note: when this PR is ready we should remove #if !FABLE_COMPILER_JAVASCRIPT directives from tests/Js/Main/TimeSpanTests.fs

@ncave ncave marked this pull request as ready for review January 14, 2025 23:47
@ncave ncave merged commit d6422f3 into fable-compiler:main Jan 14, 2025
19 checks passed
@ncave ncave deleted the fable_fcs9 branch January 14, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants