Skip to content
This repository has been archived by the owner on Mar 11, 2021. It is now read-only.

Revert "Temporary whitelist of dev cluster url (#574)" #576

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sbose78
Copy link
Member

@sbose78 sbose78 commented Aug 3, 2018

This reverts commit 63c16e8.

@alien-ike
Copy link

Ike Plugins (test-keeper)

Thank you @sbose78 for this contribution!

It appears that no tests have been added or updated in this PR.

Automated tests give us confidence in shipping reliable software. Please add some as part of this change.

If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.

For more information please head over to official documentation. You can find there how to configure the plugin.

@sbose78 sbose78 added the Hold label Aug 3, 2018
@fabric8cd
Copy link

@sbose78 snapshot fabric8-auth image is available for testing. docker pull docker.io/fabric8/fabric8-auth:SNAPSHOT-PR-576-1

@codecov
Copy link

codecov bot commented Aug 3, 2018

Codecov Report

Merging #576 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #576   +/-   ##
=======================================
  Coverage   72.05%   72.05%           
=======================================
  Files          83       83           
  Lines        8228     8228           
=======================================
  Hits         5929     5929           
  Misses       1844     1844           
  Partials      455      455

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63c16e8...881d29f. Read the comment docs.

@sbose78
Copy link
Member Author

sbose78 commented Sep 5, 2018

Hi @davidfestal do you think we could remove the temporary whitelist we had done for the devcluster deployment of Che ?

@davidfestal
Copy link

@sbose78 do you mind if we keep it a little more ? I'd like to be able to work on issue redhat-developer/rh-che#815 first, and also to test the upcoming change we still wait to have the username available in the token endpoint error message.
More generally, as soon as we remove this, we won't have any way to test the whole flow in any environment apart from the deployed production... So before removing the dev-cluster URL from this white-list, it would be great if we could setup an alternate solution to enable testing the end-to-end flow on prod-preview infrastructure: add a way to have automatic provisioning on prod-preview for certain accounts linked to a given list of email addresses for example ?

@sbose78
Copy link
Member Author

sbose78 commented Sep 5, 2018

Sure, I'll keep this for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants