Skip to content
This repository has been archived by the owner on Mar 11, 2021. It is now read-only.

Add provider side of Auth contract tests. #711

Open
wants to merge 68 commits into
base: master
Choose a base branch
from

Conversation

pmacik
Copy link
Contributor

@pmacik pmacik commented Nov 15, 2018

This PR adds provider side of the contract tests for services such as WIT or Tenant consuming Auth service API endpoints.

CICO job: openshiftio/openshiftio-cico-jobs#940

The consumer side for WIT service of the contract tests is covered by fabric8-services/fabric8-wit#2393
The consumer side for Tenant service of the contract tests is covered by fabric8-services/fabric8-tenant#767

WorkItem: https://openshift.io/openshiftio/Openshift_io/plan/detail/1329

@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

1 similar comment
@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

Copy link
Contributor

@alexeykazakov alexeykazakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that you keep both provider and client tests in Auth repo?
Isn't the client tests are supposed to be on the client side only?

@pmacik
Copy link
Contributor Author

pmacik commented Jan 8, 2019

It seems that you keep both provider and client tests in Auth repo?
Isn't the client tests are supposed to be on the client side only?

@alexeykazakov Yes, of course, you are correct. This is for the PoC, but I'm going to split the sides as I turn the POC into the actual tests.

test/contracts/consumer/consumer_test.go Outdated Show resolved Hide resolved
test/contracts/provider/provider_test.go Outdated Show resolved Hide resolved
test/contracts/provider/setup.go Outdated Show resolved Hide resolved
test/contracts/provider/setup.go Outdated Show resolved Hide resolved
test/contracts/provider/setup.go Outdated Show resolved Hide resolved
test/contracts/provider/setup.go Outdated Show resolved Hide resolved
@pmacik pmacik changed the title WIP: Add contract tests. WIP: Add provider side of WIT+Auth contract tests. Jan 14, 2019
@pmacik pmacik force-pushed the contract-tests branch 3 times, most recently from e9f3e53 to 9c669b8 Compare January 14, 2019 15:40
@alien-ike alien-ike changed the title WIP: Add provider side of WIT+Auth contract tests. Add provider side of WIT+Auth contract tests. Jan 18, 2019
@alien-ike alien-ike changed the title WIP: Add provider side of WIT+Auth contract tests. Add provider side of WIT+Auth contract tests. Jan 18, 2019
@pmacik
Copy link
Contributor Author

pmacik commented Mar 21, 2019

[test]

@pmacik
Copy link
Contributor Author

pmacik commented Apr 8, 2019

[test]

@pmacik pmacik changed the title [WIP] Add provider side of WIT+Auth contract tests. Add provider side of WIT+Auth contract tests. Apr 8, 2019
@pmacik pmacik requested a review from dipak-pawar April 8, 2019 12:50
@pmacik pmacik changed the title Add provider side of WIT+Auth contract tests. Add provider side of Auth contract tests. Apr 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants