This repository has been archived by the owner on Mar 11, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 26
Add provider side of Auth contract tests. #711
Open
pmacik
wants to merge
68
commits into
fabric8-services:master
Choose a base branch
from
pmacik:contract-tests
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can one of the admins verify this patch? |
1 similar comment
Can one of the admins verify this patch? |
pmacik
force-pushed
the
contract-tests
branch
from
November 15, 2018 13:15
880cd85
to
918536f
Compare
This was referenced Nov 22, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that you keep both provider and client tests in Auth repo?
Isn't the client tests are supposed to be on the client side only?
@alexeykazakov Yes, of course, you are correct. This is for the PoC, but I'm going to split the sides as I turn the POC into the actual tests. |
pmacik
force-pushed
the
contract-tests
branch
from
January 10, 2019 14:47
e64eb46
to
f56e21e
Compare
golangcibot
reviewed
Jan 10, 2019
pmacik
changed the title
WIP: Add contract tests.
WIP: Add provider side of WIT+Auth contract tests.
Jan 14, 2019
golangcibot
reviewed
Jan 14, 2019
pmacik
force-pushed
the
contract-tests
branch
3 times, most recently
from
January 14, 2019 15:40
e9f3e53
to
9c669b8
Compare
alien-ike
changed the title
WIP: Add provider side of WIT+Auth contract tests.
Add provider side of WIT+Auth contract tests.
Jan 18, 2019
alien-ike
changed the title
WIP: Add provider side of WIT+Auth contract tests.
Add provider side of WIT+Auth contract tests.
Jan 18, 2019
[test] |
[test] |
pmacik
changed the title
[WIP] Add provider side of WIT+Auth contract tests.
Add provider side of WIT+Auth contract tests.
Apr 8, 2019
pmacik
changed the title
Add provider side of WIT+Auth contract tests.
Add provider side of Auth contract tests.
Apr 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds provider side of the contract tests for services such as WIT or Tenant consuming Auth service API endpoints.
CICO job: openshiftio/openshiftio-cico-jobs#940
The consumer side for WIT service of the contract tests is covered by fabric8-services/fabric8-wit#2393
The consumer side for Tenant service of the contract tests is covered by fabric8-services/fabric8-tenant#767
WorkItem: https://openshift.io/openshiftio/Openshift_io/plan/detail/1329